Skip to content

Conversation

MikeMcC399
Copy link
Collaborator

Situation

  • package.json currently contains no package type field

  • Node.js now recommends in Determining module system

    In particular, package authors should always include the "type" field in their package.json files, even in packages where all sources are CommonJS.

  • npm init >=11 sets "type": "commonjs" in any newly created package.json

Change

Add

"type": "commonjs"

to package.json and place it under the license key, where npm init would put it.

Comment

Although this is intended to be a maintenance task only, it does cause the action to be rebuilt with a different internal bundling order concerning the CommonJS src/ping.js utility. It is therefore classed with a fix: commit message.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added the type: enhancement New feature or request label Sep 26, 2025
@MikeMcC399 MikeMcC399 self-assigned this Sep 26, 2025
@MikeMcC399 MikeMcC399 marked this pull request as ready for review September 26, 2025 08:51
@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 requested review from jennifer-shehane and removed request for jennifer-shehane October 17, 2025 09:13
@MikeMcC399

This comment was marked as resolved.

@jennifer-shehane jennifer-shehane merged commit e65cba2 into cypress-io:master Oct 23, 2025
79 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the add/type-commonjs branch October 23, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants