fix: add type commonjs to package.json #1544
Merged
+88
−87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
package.json currently contains no package type field
Node.js now recommends in Determining module system
npm init
>=11
sets"type": "commonjs"
in any newly createdpackage.json
Change
Add
to package.json and place it under the
license
key, wherenpm init
would put it.Comment
Although this is intended to be a maintenance task only, it does cause the action to be rebuilt with a different internal bundling order concerning the CommonJS src/ping.js utility. It is therefore classed with a
fix:
commit message.